Submission Details
Severity:
it is better to implement the while loop like this.
Summary
Implementing the while loop in this way can consume less gas.
Vulnerability Details
function areListsValid(address[] calldata recipients, uint256[] calldata amounts) external pure returns (bool) {
if (recipients.length == 0) {
return false;
}
if (recipients.length != amounts.length) {
return false;
}
=> for (uint256 i; i < recipients.length; i++) {
if (recipients[i] == address(0)) {
return false;
}
if (amounts[i] == 0) {
return false;
}
=> for (uint256 j = i + 1; j < recipients.length; j++) {
if (recipients[i] == recipients[j]) {
return false;
}
}
}
return true;
}
}
Impact
gas consumption.
Tools Used
Recommendations
like this :
for (uint256 i; i < recipients.length) {
if (recipients[i] == address(0)) {
return false;
}
if (amounts[i] == 0) {
return false;
}
for (uint256 j = i + 1; j < recipients.length) {
if (recipients[i] == recipients[j]) {
return false;
}
unchecked {
++i;
}
}
unchecked {
++i;
}
}
Prize pool breakdown
Total prize
15,000 USDC
nSLOC
25659 USDC / LOC
12,500 USDC
1,375 USDC
1,125 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.