Beanstalk: The Finale

Summary

This report identifies a potential issue in PipelineConvertFacet.sol that could lead to locked ETH within the contract. The issue is related to the pipelineConvert function being marked as payable even though it doesn't process ETH payments directly.

Vulnerability Details

The pipelineConvert function in the PipelineConvertFacet contract allows users to convert various tokens through a series of pipeline calls. While the function itself doesn't handle ETH directly, it is marked as payable.

This means that users could accidentally or intentionally send ETH along with the function call. The contract currently lacks functionality to handle this ETH. Since the function doesn't expect ETH payments, it doesn't process them and the sent ETH would be locked in the contract.

Impact

Loss of funds: Any ETH accidentally or intentionally sent through pipelineConvert will be locked in the contract and inaccessible.

Tools Used

Manual code review

Recommendations

Remove the payable modifier from the pipelineConvert function. This will prevent users from accidentally sending ETH along with the function call.

Consider adding a comment or documentation explaining that the function does not accept ETH payments.

If future functionalities within PipelineConvertFacet require ETH payments for specific purposes within the pipeline conversion process, implement a secure mechanism to handle them. This mechanism should clearly explain the purpose of ETH payments and ensure proper processing and withdrawal for authorized users.