Dangerous strict equalities allows the contract to be easily manipulated.
Summary
Use of strict equalities that can be easily manipulated by an attacker.
Vulnerability Details
LibTransfer.sendToken(IERC20,uint256,address,LibTransfer.To) (contracts/libraries/Token/LibTransfer.sol#68-72) uses a dangerous strict equality:
- amount == 0 (contracts/libraries/Token/LibTransfer.sol#69)
LibTransfer.sendToken(IERC20,uint256,address,LibTransfer.To) (contracts/beanstalk/migration/L1Libraries/LibTransfer.sol#71-75) uses a dangerous strict equality:
- amount == 0 (contracts/beanstalk/migration/L1Libraries/LibTransfer.sol#72)
Impact
The contract will get stuck in an infinite loop if there are not enough tokens to send.
Tools Used
Slither
Recommendations
Don't use strict equality to determine if an account has enough Ether or tokens.
Prize pool breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.