Submission Details
Severity:
`SeasonGettersFacet.totalDeltaB()` uses single Well for calculations
Summary
As you can see it uses Bean / ETH Well instead of calculating deltaB for all whitelisted Wells:
https://github.com/Cyfrin/2024-05-beanstalk-the-finale/blob/df2dd129a878d16d4adc75049179ac0029d9a96b/protocol/contracts/beanstalk/sun/SeasonFacet/SeasonGettersFacet.sol#L96-L98
function totalDeltaB() external view returns (int256 deltaB) {
deltaB = LibWellMinting.check(C.BEAN_ETH_WELL);
}
Probably it was missed while implementing Whitelist v1.1
Impact
SeasonGettersFacet.totalDeltaB() returns incorrect result.
Tools Used
Manual Review
Recommendations
Loop through whitelisted Wells to calculate total deltaB.
Updates
Lead Judging Commences
inallhonesty 12 months ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
SeasonGettersFacet returns the wrong totalDeltaB
Appeal created
T1MOH
12 months ago
inallhonesty
12 months ago
inallhonesty 12 months ago
Submission Judgement Published Assigned finding tags:
SeasonGettersFacet returns the wrong totalDeltaB
Prize pool breakdown
Total prize
250,000 USDC
nSLOC
12,28520 USDC / LOC
220,000 USDC
10,000 USDC
20,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.