Submission Details
Severity:
If token get's unwhitelisted, users will be unable to claim the `plenty` they've accrued prior to the unwhitelist
Summary
Users might lose their plenty
Vulnerability Details
When users mow, if a sop season has occurred since lastUpdate, they're calculated their plenty for each of the currently whitelisted tokens.
// If a Sop has occured since last update, calculate rewards and set last Sop.
if (s.sys.season.lastSopSeason > lastUpdate) {
address[] memory tokens = LibWhitelistedTokens.getWhitelistedWellLpTokens();
for (uint i; i < tokens.length; i++) {
s.accts[account].sop.perWellPlenty[tokens[i]].plenty = balanceOfPlenty(
account,
tokens[i]
);
}
s.accts[account].lastSop = s.sys.season.lastSop;
}
This could be problematic as if the user has had previous uncalculated plenty for a token that's now unwhitelisted, they won't be able to claim for it.
Impact
Loss of funds
Tools Used
Manual review
Recommendations
Fix is non-trivial
Updates
Lead Judging Commences
inallhonesty about 1 year ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
Informational/Gas
Invalid as per docs https://docs.codehawks.com/hawks-auditors/how-to-determine-a-finding-validity
Appeal created
deadrosesxyz
about 1 year ago
inallhonesty
about 1 year ago
inallhonesty about 1 year ago
Submission Judgement Published Assigned finding tags:
If token get's unwhitelisted, users will be unable to claim the `plenty` they've accrued prior to the unwhitelist
Prize pool breakdown
Total prize
250,000 USDC
nSLOC
12,28520 USDC / LOC
220,000 USDC
10,000 USDC
20,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.