Submission Details
Severity:
`redeemDepositsAndInternalBalances` should mow before adding migrated deposits
Summary
redeemDepositsAndInternalBalances should mow before adding migrated deposits
Vulnerability Details
The redeemDepositsAndInternalBalances will add stalk, roots and bdv to a user's profile, but will not set their necessary variables (lastSop, lastUpdated and lastRain) as appropriate. Because of this, when mowing the next time, the user will accrue plenty as if they've had these deposits since their lastUpdate (which can even be 0).
Worst case scenario, user could be able to drain the protocol.
Impact
Loss of funds
Tools Used
Manual review
Recommendations
Mow before adding migrated deposits
Updates
Appeal created
deadrosesxyz
about 1 year ago
inallhonesty
about 1 year ago
inallhonesty about 1 year ago
Submission Judgement Published Assigned finding tags:
`redeemDepositsAndInternalBalances` should mow before adding migrated deposits
Prize pool breakdown
Total prize
250,000 USDC
nSLOC
12,28520 USDC / LOC
220,000 USDC
10,000 USDC
20,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.