Submission Details
Severity:
`ReseedSilo#reseedSiloDeposit` does not credit the user any `roots`
Summary
ReseedSilo#reseedSiloDeposit does not credit the user any roots
Vulnerability Details
Usually, when users are minted stalk, they're also minted roots at the current Silo ratio.
However, within reseedSiloDeposit, roots are never actually calculated/set.
// increment stalkForAccount by the stalk issued per BDV.
// placed outside of loop for gas effiency.
accountStalk += stalkIssuedPerBdv * totalBdvForAccount;
// set stalk for account.
s.accts[deposits.accounts].stalk = accountStalk;
}
As this would also increase the roots : stalk ratio, this would allow for unfair minting of Beans
Impact
Loss of roots and Beans
Tools Used
Manual review
Recommendations
Mint roots at the current silo ratio
Updates
Lead Judging Commences
inallhonesty over 1 year ago
Submission Judgement Published Assigned finding tags:
`ReseedSilo#reseedSiloDeposit` does not credit the user any `roots`
Appeal created
deadrosesxyz
over 1 year ago
inallhonesty
over 1 year ago
inallhonesty about 1 year ago
Submission Judgement Published Assigned finding tags:
`ReseedSilo#reseedSiloDeposit` does not credit the user any `roots`
Prize pool breakdown
Total prize
250,000 USDC
nSLOC
12,28520 USDC / LOC
220,000 USDC
10,000 USDC
20,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.