DeFiHardhatFoundry
250,000 USDC
View results
Submission Details
Severity: low
Invalid

`ReseedSilo` does not account for germinating stalk

Summary

ReseedSilo does not account for germinating stalk

Vulnerability Details

When migrating deposits, the user's stalk is calculated and is immediately minted as grown

accountStalk += stalkIssuedPerBdv * totalBdvForAccount;
// set stalk for account.
s.accts[deposits.accounts].stalk = accountStalk;

However, if the user's deposit has happened in this or the previous season, their deposit should actually only give them germinating stalk.

Impact

Unfair germination of stalk and gaining of voting power.

Tools Used

Manual review

Recommendations

If user's stem is >= germTip set the stalk as germinating

Updates

Lead Judging Commences

inallhonesty Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

`ReseedSilo` does not account for germinating stalk

Appeal created

deadrosesxyz Submitter
about 1 year ago
inallhonesty Lead Judge
about 1 year ago
inallhonesty Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

`ReseedSilo` does not account for germinating stalk

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.