DeFiHardhatFoundry
250,000 USDC
View results
Submission Details
Severity: medium
Valid

`fundsSafu` modifier will be useless on L2 before all users have successfully migrated.

Summary

fundsSafu modifier will be useless on L2 before all users have successfully migrated.

Vulnerability Details

When calculating the token entitlements, the contract will not take into account the funds that are already transferred, but waiting users to claim them (e.g. via L2ContractMigrationFacet#redeemDepositsAndInternalBalances.

This would make the modifier useless until all users have successfully redeemed their deposits and would allow for exploits to happen.

Impact

Invariable will be useless and will allow for exploits to happen.

Tools Used

Manual review

Recommendations

Add the to-be-claimed funds in Invariable

Updates

Lead Judging Commences

inallhonesty Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Lack of quality
Assigned finding tags:

Quality

Appeal created

deadrosesxyz Submitter
about 1 year ago
inallhonesty Lead Judge
about 1 year ago
inallhonesty Lead Judge about 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

`fundsSafu` doesn't properly implement the entitlement calculation - funds to be migrated

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.