Beanstalk: The Finale
Beanstalk
DeFiHardhatFoundry
250,000 USDC
View results
Previous Next
Submission Details
Severity: low
Invalid

RessedSun should be paused until migration of reseed is complete

asefewwexa

Line of code

https://github.com/Cyfrin/2024-05-beanstalk-the-finale/blob/df2dd129a878d16d4adc75049179ac0029d9a96b/protocol/contracts/beanstalk/init/reseed/L2/ReseedSun.sol#L36

Summary

RessedSun should be paused until migration of reseed is complete, so sunrise is not called preemptively

Vulnerability Details

sun rise can be permissionlessly called to roll forward season, but the protocol should ensure that all state variable such as pods, harvestable, and harvested are set before any user can trigger a sunrise.

s.sys.field.pods = totalPods;
s.sys.field.harvestable = harvestable;
s.sys.field.harvested = harvested;

Impact

Sunrise will be triggered when important variables have not yet been set

Tools Used

manual review

Recommendations

RessedSun should be paused until migration of reseed is complete, so sunrise is not called preemptively

Updates

Lead Judging Commences

inallhonesty Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Incorrect statement

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.