DeFiHardhatFoundry
250,000 USDC
View results
Submission Details
Severity: medium
Valid

Smart contract which own Fertilizer will lose it after migration to L2

Summary

Smart contracts won't have the same address on L2 after migration, that it why you introduce L2ContractMigrationFacet.sol. Via this Facet owners of smart contracts can migrate Internal Balances and Silo deposits to any receiver they specify.

However there is missing logic for Fertilizer ERC1155 migration. There is only ReseedBarn.sol which mints Fertilizer to account, but it's similar to ReseedInternalBalances.sol - Fertilizer can be minted only to EOA owners, because address of smart contract on L2 is not known in advance.

Impact

Smart contract which own Fertilizer will lose it after migration to L2

Tools Used

Manual Review

Recommendations

Develop a way to migrate Fertilizer from smart contract owners in similar way you did with Internal Balances and Silo Deposits.

Updates

Lead Judging Commences

inallhonesty Lead Judge 12 months ago
Submission Judgement Published
Invalidated
Reason: Incorrect statement
Assigned finding tags:

Potential Loss of Fertilizer ERC1155 NFTs During L1 to L2 Migration - Account abstraction, multisig other contracts

Appeal created

inallhonesty Lead Judge 11 months ago
Submission Judgement Published
Validated
Assigned finding tags:

Potential Loss of Fertilizer ERC1155 NFTs During L1 to L2 Migration - Account abstraction, multisig other contracts

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.