DeFiHardhatFoundry
250,000 USDC
View results
Submission Details
Severity: medium
Invalid

no reentry check used,

Summary

modifier

modifier nonReentrant() was not used in

protocol/contracts/beanstalk/sun/OracleFacet.sol

Vulnerability Details

https://github.com/Cyfrin/2024-05-beanstalk-the-finale/blob/4e0ad0b964f74a1b4880114f4dd5b339bc69cd3e/protocol/contracts/beanstalk/sun/OracleFacet.sol#L16

depends which function will be used some price manipulation possible

Impact

price manipulation especially when using lookback = 0, where chainlink might be broken at the time

Tools Used

hardhat, slither, echinda

Recommendations

use nonReentrant according to design in mind of coder of this code.

Updates

Lead Judging Commences

inallhonesty Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Lack of quality

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.