The current implementation uses the following constants for the calculations
So it assumes that the difference between L1 Block time and L2 block time is 6 fold, which is actually only true for the Optimism-based chain, for example on a chain like Arbitrum it will completely mess up the calculations.
Also, Dev mentioned the chain the on which code deployed is not final and it will be chosen via governance and if the governance chooses any chain for which these params don't hold it will completely mess up the delta calculation in the morningTemperature
function which is the core function for the correct working of the field facet.
In this case the impace is medium, chances of such chain being approved through governance are low but are present and if go through could mess up whole field facet calculations in multiple functions like totalSoil
and _totalSoilAndTemperature
Brain
Instead of making them constant make these values immutable and pass via constructor on deployment.
The contest is live. Earn rewards by submitting a finding.
This is your time to appeal against judgements on your submissions.
Appeals are being carefully reviewed by our judges.