DeFiHardhatFoundry
250,000 USDC
View results
Submission Details
Severity: medium
Invalid

wrong initliazation or just typo in description in L2/ ReseedBean.sol

Summary

https://github.com/Cyfrin/2024-05-beanstalk-the-finale/blob/4e0ad0b964f74a1b4880114f4dd5b339bc69cd3e/protocol/contracts/beanstalk/init/reseed/L2/ReseedBean.sol#L22

// TODO: replace with implmentation once developed.
address internal constant CP2_U_BEAN_ETH_WELL_IMPLMENTATION = address(0);
address internal constant CP2_U_BEAN_WSTETH_WELL_IMPLMENTATION = address(0);
address internal constant SS_U_BEAN_STABLE_WELL_IMPLMENTATION = address(0);

Vulnerability Details

Can accidentally deploy proxy with 0 implementation and try to init it.

Impact

Needed redeploy or just dev time.

Tools Used

slither

Recommendations

do checks if proxy is deployed with nonzero implementation

in line 161, 175, 194,

or split into two steps one deploying all proxies with proper name of proxies, and the make update script to update implementation to non zero and init.

Good practice name of the proxy correspond to the proxy implementation, yes it ads one layer of inheritance, but after revealing the code you it easier to analyze because not every proxy revelaed contract name is ERC1967

Updates

Lead Judging Commences

inallhonesty Lead Judge 11 months ago
Submission Judgement Published
Invalidated
Reason: Design choice

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.