DeFiHardhatFoundry
250,000 USDC
View results
Submission Details
Severity: low
Invalid

In `Account.sol` the structs Deposit, GerminatingStalk and MowStatus do not have a reserved storage _buffer for future additions which contradicts the comments

Summary

https://github.com/Cyfrin/2024-05-beanstalk-the-finale/blob/main/protocol/contracts/beanstalk/storage/Account.sol#L96-L102

https://github.com/Cyfrin/2024-05-beanstalk-the-finale/blob/main/protocol/contracts/beanstalk/storage/Account.sol#L108-L113

https://github.com/Cyfrin/2024-05-beanstalk-the-finale/blob/main/protocol/contracts/beanstalk/storage/Account.sol#L120-L125

Vulnerability Details

As per the code comments in the links above, the structs: Deposit, GerminatingStalk and MowStatus were supposed to have a buffer parameter which would allow any additions in the future but in the current code, the _buffer parameter is missing

Impact

Since there is no _buffer storage reserve, adding additional fields in these structs won't be possible in the future

Tools Used

Manual Review

Recommendations

Add a _buffer field to these structs

Updates

Lead Judging Commences

inallhonesty Lead Judge 11 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.