Submission Details
Severity:
The retrieveAdmin function does not work properly
Summary
The Laundrette:retrieveAdmin() function does not work properly.
Vulnerability Details
Only the executor role has permission to execute instructions. Therefore,external call to Kernel::executeAction() within retrieveAdmin() will revert.
function retrieveAdmin() external {
kernel.executeAction(Actions.ChangeAdmin, kernel.executor());
}
POC
function test_tryToRetrieveAdmin() public {
vm.prank(godFather);
vm.expectRevert();
laundrette.retrieveAdmin();
}
Place the PoC into test/Laundrette.t.sol.t.sol, and execute with
forge test --mt test_tryToRetrieveAdmin -vvvv
Impact
The retrieveAdmin function does not work properly
Tools Used
Manual review, Foundry
Recommendations
The Godfather directly calls executeAction instead of calling it within the Laundrette contract
kernel.executeAction(Actions.ChangeAdmin, godFather)
Updates
Lead Judging Commences
n0kto over 1 year ago
Submission Judgement Published Assigned finding tags:
`retrieveAdmin` not working
Rewards breakdown
nSLOC
205This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.