First Flight #16: Mafia Takedown

Summary

This codebase is not very well documented. The readme is good, but no natspec and descriptions of the inner workings makes this harder to read. Maybe tht is the point.

Vulnerability Details

Security through obscurity is not really a thing, its just an annoyance.

Impact

Admittedly it makes this harder to decipher, which may be the point, but along with the other issues, this points to a general lack of engineering sophistication within this project.

Tools Used

Recommendations

Put in comments which describe the core functions and interactions of the protocol. The GodFather is going to have to get dirty with this codebase if they are going to have any chance of salvaging anything, and I am sure they would appreciate some better signposts.