Submission Details
Severity:
`onlyRole` modifier is not required for `Laundrette::addToTheGang` function
Description
Laundrette::addToTheGang can only be called by the godFather hence Laundrette::isGodFather modifier is enough for this function
Impact
For every added member Laundrette::addToTheGang function some extra gas is spent by checking for onlyRole
Proof of Concept
function addToTheGang(address account) external onlyRole("gangmember") <-@ {
...
...
..
.
}
Recommended Mitigation
The onlyRole modifier in Laundrette::addToTheGang function is not required and can be safely removed.
Rewards breakdown
nSLOC
205This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.