Submission Details
Severity:
The KEYCODES should be bytes3 not bytes5 as per Default FrameWork Recommendation
Description
The Default FrameWork docs describe that modules should be named with KEYCODES which are bytes3 i.e three characters to discourage module bloat and reduce potential confusion around dependency names but the KEYCODES are bytes5 instead which are 5 characters long
Impact
There may be module bloat and potential confusion around dependency names
Proof of Concept
MoneyShelf.sol KEYCODE
function KEYCODE() public pure override returns (Keycode) {
return Keycode.wrap("MONEY");
}
WeaponShelf.sol KEYCODE
function KEYCODE() public pure override returns (Keycode) {
return Keycode.wrap("WEAPN");
}
Recommended Mitigation
It is recommended follow Default Framework docs and use bytes3 instead of bytes5 in the KEYCODES i.e changing MONEY to MNY and WEAPN to WPN
Updates
Rewards breakdown
nSLOC
205This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.