First Flight #16: Mafia Takedown

Summary

The Laundrette::retrieveAdmin , as the name suggests it should only retrieve who the Admin is but in its description it is changing the admin.

Impact

As the name of the function and functioning suggest different things , wrong calling of the function maybe done which may cause the different action to be made instead of the desired action.

Tools Used

slither , aderyn , manual review

Recommendations

1. A proper natspec should be provided about the function , what is it doing and what the different components are for.

2. Name the function appropriately.

3. The function should be made to only be called by the GodFather for now to ensure security and avoid any mishappening.