Submission Details
Severity:
`CrimeMoney::kernel` & `MoneyVault::usdc and MoneyVault::crimeMoney` & `MoneyShelf::usdc & MoneyShelf::crimeMoney` should be marked immutable , as it is defined only once in the contract
Summary
CrimeMoney.sol
contract CrimeMoney is ERC20 {
-->> Kernel public kernel;
constructor(Kernel _kernel) ERC20("CrimeMoney", "CRIME") {
-->> kernel = _kernel;
}
}
MoneyVault,sol
contract MoneyVault is Shelf {
-->> IERC20 private usdc;
-->> CrimeMoney private crimeMoney;
constructor(Kernel kernel_, IERC20 _usdc, CrimeMoney _crimeMoney) Shelf(kernel_) {
usdc = _usdc;
crimeMoney = _crimeMoney;
}
}
MoneyShelf.sol
contract MoneyShelf is Shelf {
IERC20 private usdc;
CrimeMoney private crimeMoney;
constructor(Kernel kernel_, IERC20 _usdc, CrimeMoney _crimeMoney) Shelf(kernel_) {
-->> usdc = _usdc;
-->> crimeMoney = _crimeMoney;
}
}
Impact Extra gas fee
Tools Used
manual review
Recommendations
Should be made immutable
Rewards breakdown
nSLOC
205This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.