First Flight #16: Mafia Takedown
First Flight #16
Beginner FriendlyDeFiFoundry
100 EXP
View results
Previous Next
Submission Details
Severity: high
Valid

Wrong dependency configuration, leading to EmergencyMigration to fail

wetzo

Summary

Dependency configuration in Laundrette.sol::configureDependencies is not properly set, with index 0 overwritten.

Vulnerability Details

The index 0 of dependencies is first set to toKeycode("MONEY") but then immediately overridden by toKeycode("WEAPN") by mistake. This prevents the address of moneyShelf to change to moneyVault in case of EmergencyMigration.

Impact

The return value of Laundrette.sol::configureDependencies will be unexpected. In case of EmergencyMigration, the dependencies will not be updated as intended and the deposit and withdraw functions will not be restricted, potentially leading to fund loses as the protocol will not be frozen.

Tools Used

Manual review

Recommendations

- dependencies[0] = toKeycode("WEAPN");
+ dependencies[1] = toKeycode("WEAPN");
Updates

Lead Judging Commences

n0kto Lead Judge over 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

Laundrette incorrect dependencies

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.