First Flight #16: Mafia Takedown

Summary

Missing checks for address(0) when assigning values to address state variables

Vulnerability Details

Check for address(0) when assigning values to address state variables.
Check for address(0) when assigning values to address state variables.

• Found in src/CrimeMoney.sol Line: 11

  kernel = _kernel;

• Found in src/Kernel.sol Line: 65

  kernel = kernel_;

• Found in src/Kernel.sol Line: 74

  kernel = newKernel_;

• Found in src/Kernel.sol Line: 209

  executor = target_;

• Found in src/Kernel.sol Line: 211

  admin = target_;

• Found in src/Kernel.sol Line: 226

  getModuleForKeycode[keycode] = newModule_;

• Found in src/Kernel.sol Line: 346

  modulePermissions[request.keycode][policy_][request.funcSelector] = grant_;

• Found in src/modules/MoneyShelf.sol Line: 16

  usdc = _usdc;

• Found in src/modules/MoneyShelf.sol Line: 17

  crimeMoney = _crimeMoney;

• Found in src/modules/MoneyVault.sol Line: 18

  usdc = _usdc;

• Found in src/modules/MoneyVault.sol Line: 19

  crimeMoney = _crimeMoney;

• Found in src/modules/Shelf.sol Line: 13

  bank[account] += amount;

• Found in src/modules/Shelf.sol Line: 17

  bank[account] -= amount;

Tools Used

Static Analysis (Aderyn)

Recommendations

Check for address(0) when assigning values to address state variables.