First Flight #16: Mafia Takedown

Summary

The Laundrette::configureDependencies function has an issue where the second dependency is assigned to the wrong index in the dependencies array.

Vulnerability Details

In the Laundrette::configureDependencies function, the second dependency is assigned to the dependencies array as follows:

However, the first dependency has already been assigned to dependencies[0] in the previous line:

This means that the second dependency is overwriting the first dependency, which is likely not the intended behavior

Impact

the Laundrette contract will only have one dependency set correctly (the "WEAPN" module), and the "MONEY" module dependency will be overwritten. This will lead to failures when the contract tries to interact with the "MONEY" module.

Tools Used

Manual Review

Recommendations

To fix this issue, the line assigning the second dependency should be updated to use the correct index: