Submission Details
Severity:
The `Godfather` can’t withdraw money.
Summary
Godfather is not able to withdraw USDC because does not have the gangmember role.
Vulnerability Details
function withdrawMoney(
address account,
address to,
uint256 amount
)
external
onlyRole("gangmember")
isAuthorizedOrRevert(account)
{
moneyShelf.withdrawUSDC(account, to, amount);
}
Impact
Godfather can’t withdraw money. (USDC from the Moneyshelf module)
Tools Used
Manual review
Recommendations
Write a modifier that comprehends both gang members and Godfather and add it to the function as access control.
Make this change to the code:
function withdrawMoney(
address account,
address to,
uint256 amount
)
external
- onlyRole("gangmember")
+ onlyRole(“gangmember or Godfather”);
isAuthorizedOrRevert(account)
{
moneyShelf.withdrawUSDC(account, to, amount);
}
Updates
Lead Judging Commences
n0kto about 1 year ago
Submission Judgement Published Assigned finding tags:
GodFather is not a gang member
Rewards breakdown
nSLOC
205This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.