Submission Details
Severity:
Safe ERC20 operations not used.
Summary
There are standard ERC20 operations (not safe) used in modules
Vulnerability Details
transferFrom vs safetransferFrom
function depositUSDC(address account, address to, uint256 amount) external {
deposit(to, amount);
usdc.transferFrom(account, address(this), amount);
crimeMoney.mint(to, amount);
}
transfer vs safetransfer
function withdrawUSDC(address account, address to, uint256 amount) external {
withdraw(account, amount);
crimeMoney.burn(account, amount);
usdc.transfer(to, amount);
}
Impact
Impact deriving from not using [Safe] (functionshttps://medium.com/@JohnnyTime/why-you-should-always-use-safeerc20-94f44aa852d8#:~:text=These%20%E2%80%9Csafe%E2%80%9D%20functions%20make%20sure,don't%20break%20our%20protocol.)
Tools Used
Manual review
Recommendations
Use safe ERC20 operations
Rewards breakdown
nSLOC
205This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.