First Flight #16: Mafia Takedown
First Flight #16
Beginner FriendlyDeFiFoundry
100 EXP
View results
Previous Next
Submission Details
Severity: low
Valid

retrieveAdmin does not work

octeezy

Summary

retrieveAdmin is supposed to work as a way to set the admin role back to the executor, but this is done through kernel.executeAction which is an executor only function.

Vulnerability Details

In the current setup Launderette is the Admin and godFather the executor which means that kernel.executeAction will rever as it's has the OnlyExecutor modifier.

Impact

MEDIUM - doesn't work as intended but functionality can be reached by other means anyways.

Tools Used

Foundry test

function testAttackerCanRemoveAdmin() public {
vm.prank(kernel.executor());
vm.expectRevert();
laundrette.retrieveAdmin();
}

Recommendations

This functionality is at odds with the intended functionality of the Kernel executeAction function, instead to achieve this functionality the executor should call the executeAction function directly

Updates

Lead Judging Commences

n0kto Lead Judge about 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

`retrieveAdmin` not working

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.