Submission Details
Severity:
setting value to false in constructor, might increase gas cost a bit
Summary
In ChoosingRam.sol::isRamSelected is being set as false. Though this is fine, we are just setting the value to false which is already false by default. so, this might cost a little bit of more gas during deployment
Vulnerability Details
Proof to show that value of isRamSelected is false by default:
Place below code in Dussehra.t.sol and run command - forge test --mt test__isRamSelectedValueIsFalseByDefault
code
function test__isRamSelectedValueIsFalseByDefault() public {
ramNFT = new RamNFT();
choosingRam = new ChoosingRam(address(ramNFT));
assertEq(choosingRam.isRamSelected(), false);
}
Impact
increase in gas cost during deployment
Tools Used
Foundry
Recommendations
constructor(address _ramNFT) {
- isRamSelected = false;
ramNFT = RamNFT(_ramNFT);
}
Updates
Lead Judging Commences
bube about 1 year ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
Info/Gas/Invalid according to docs
Rewards breakdown
nSLOC
218This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.