First Flight #17: Dussehra
First Flight #17
Beginner FriendlyFoundryNFT
100 EXP
View results
Previous Next
Submission Details
Severity: low
Invalid

Not using best practices in naming convention for state variables, resulting in lack of better readability for developers

Mahith

Summary

Any code is written once, but read a lot of times. so, we need to ensure that our code readability is very high such that anyone can easily understand our code.

Hence, use s_ prefix for state variables and i_ for immutable variables for better readability and differentiating it from local variables

Recommendations

Make sure to improve the code as shown below:

for RamNFT.sol

code
- uint256 public tokenCounter;
- address public organiser;
- address public choosingRamContract;
​
+ uint256 public s_tokenCounter;
+ address public i_organiser;
+ address public s_choosingRamContract;

for ChoosingRam.sol

code
- bool public isRamSelected;
- RamNFT public ramNFT;
- address public selectedRam;
​
+ bool public s_isRamSelected;
+ RamNFT public i_ramNFT;
+ address public s_selectedRam;

for Dussehra.sol

code
- address[] public WantToBeLikeRam;
- uint256 public entranceFee;
- address public organiser;
- address public SelectedRam;
- RamNFT public ramNFT;
- bool public IsRavanKilled;
- mapping(address competitor => bool isPresent) public peopleLikeRam;
- uint256 public totalAmountGivenToRam;
- ChoosingRam public choosingRamContract;
​
+ address[] public s_WantToBeLikeRam;
+ uint256 public i_entranceFee;
+ address public i_organiser;
+ address public s_SelectedRam;
+ RamNFT public i_ramNFT;
+ bool public s_IsRavanKilled;
+ mapping(address competitor => bool isPresent) public s_peopleLikeRam;
+ uint256 public s_totalAmountGivenToRam;
+ ChoosingRam public i_choosingRamContract;

Updates

Lead Judging Commences

bube Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

Info/Gas/Invalid according to docs

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.