Beginner FriendlyFoundryNFT
100 EXP
View results
Submission Details
Severity: low
Invalid

Some state variables can be immutable.

Summary

Some state variables can be marked as immutable to make contacts more gas efficient.

Vulnerability Details

The state variables specified in the Relevant GitHub Links can be marked as immutable.
This would allow the contracts to be a little bit more gas efficient

Impact

Contracts lose a minor amount of gas since they are not as efficient as possible

Tools Used

Slither, Manual Review

Recommendations

Make the following state variables immutable.

  • For src/ChoosingRam.sol:

- RamNFT public ramNFT;
+ RamNFT public immutable ramNFT;
  • For src/RamNFT.sol:

- address public organiser;
+ address public immutable organiser;
  • For src/Dussehra.sol:

- uint256 public entranceFee;
- address public organiser;
+ uint256 public immutable entranceFee;
+ address public immutable organiser;
- RamNFT public ramNFT;
+ RamNFT public immutable ramNFT;
- ChoosingRam public choosingRamContract;
+ ChoosingRam public immutable choosingRamContract;
Updates

Lead Judging Commences

bube Lead Judge over 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

Info/Gas/Invalid according to docs

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.