First Flight #17: Dussehra

Vulnerability Details

The Dussehra::killRavana function has a modifier that checks if ChoosingRam::isRamSelected is true. However, in the ChoosingRam::increaseValuesOfParticipants function the characteristics are updating, the ChoosingRam::isRamSelected flag is not set to true. This means that users will not be able to kill Ravana and claim the reward amount. Only the organiser can set ChoosingRam::isRamSelected to true in ChoosingRam::selectRamIfNotSelected if the participant did not set it after that time. This allows the organiser to call this function to set the flag to true and earn the reward amount.

Impact

Users will not be able to kill Ravana if ChoosingRam::increaseValuesOfParticipants is not true. This means users will not be able to get the reward amount.

Tools Used

Manual Review

Recommendations

Modify the ChoosingRam::increaseValuesOfParticipants function in the ChoosingRam contract to set the ChoosingRam::isRamSelected flag to true when the user meets the necessary conditions.