Submission Details
Severity:
Missing Token Existence Check in updateCharacteristics Function
Summary
The updateCharacteristics function in the RamNFT contract lacks a check to validate the existence of the specified token (tokenId) before updating its characteristics. Without this validation step, there is a risk of manipulating non-existing tokens or encountering errors related to token absence.
Impact
The lack of token existence validation opens up the possibility of unauthorized manipulation of non-existent tokens within the contract.
Tools Used
manual code review
Recommendations
function updateCharacteristics(
uint256 tokenId,
bool _isJitaKrodhah,
bool _isDhyutimaan,
bool _isVidvaan,
bool _isAatmavan,
bool _isSatyavaakyah
) public onlyChoosingRamContract {
require(_tokenExists(tokenId), "Token does not exist.");
Characteristics[tokenId] = CharacteristicsOfRam({
ram: Characteristics[tokenId].ram,
isJitaKrodhah: _isJitaKrodhah,
isDhyutimaan: _isDhyutimaan,
isVidvaan: _isVidvaan,
isAatmavan: _isAatmavan,
isSatyavaakyah: _isSatyavaakyah
});
}```
Rewards breakdown
nSLOC
218This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.