First Flight #17: Dussehra
First Flight #17
Beginner FriendlyFoundryNFT
100 EXP
View results
Previous Next
Submission Details
Severity: low
Valid

Improper timestamps used in `Dussehra::killRavana`

enchev

Summary

Improper timestamps used in Dussehra::killRavana which shortens or extends the time for not reverting the method in time ranges in which the method must behave differently.

Vulnerability Details

The method Dussehra::killRavana uses the following improper timestamps:

  • if (block.timestamp < 1728691069) { which represents before Oct 12 2024 02:57:49 but it should represent Oct 12 2024 00:00:00 instead.

  • if (block.timestamp > 1728777669) { which represents after Oct 13 2024 00:01:09 but it should represent Oct 13 2024 00:00:00 instead.

Impact

  • Makes the method reverting if called on in the time range Oct 12 2024 00:00:00 - Oct 12 2024 02:57:49

  • Makes the method not revert if called in the time range Oct 13 2024 00:00:00 - Oct 13 2024 00:01:09

Tools Used

Manual Review

Recommendations

Use proper timestamp periods and also inclusive operator:

- if (block.timestamp < 1728691069) {
+ if (block.timestamp <= 1728691200) {
- if (block.timestamp > 1728777669) {
+ if (block.timestamp <= 1728777600) {
Updates

Lead Judging Commences

bube Lead Judge over 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

Incorrect timestamp

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.