First Flight #17: Dussehra
First Flight #17
Beginner FriendlyFoundryNFT
100 EXP
View results
Previous Next
Submission Details
Severity: low
Valid

Implemented literal Integer within `Dussehra::killRavana` not in line with readme documentation

AuditorNate

Summary

Implemented literal integer gives conflicting dates when compared to the readme documentation. Unsure if this is an oversite.

Vulnerability Details

function killRavana() public RamIsSelected {
//@AN - 1728691069 == Date and Time: Friday, November 8, 2024, 02:44:29 UT
if (block.timestamp < 1728691069) {
revert Dussehra__MahuratIsNotStart();
}
//@AN - 1728777669 == Date and Time: Monday, November 11, 2024, 02:41:09 UTC
​
if (block.timestamp > 1728777669) {
revert Dussehra__MahuratIsFinished();
}

Thus would not allow the event to run for almost a month after stated time.

Converted the literal integers and was given the following results

728691069 == Date and Time: Friday, November 8, 2024, 02:44:29 UT
1728777669 == Date and Time: Monday, November 11, 2024, 02:41:09 UTC

This is not in line with the following exert from the readme documentation.

killRavana—Allows users to kill Ravana, and the Organizer will receive half of the total amount collected in the event. This function will only work after 12 October 2024 and before 13 October 2024.

Impact

Impact varies, assigning this a low. The functionality of the event is tied to these implemented integers. So dev should update the readme or integers to be in line with the protocols desired event time.

Tools Used

Manual analysis

Recommendations

Either change the implemented integers or re write the killRavana readme section to show correct dates.

Updates

Lead Judging Commences

bube Lead Judge over 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

Incorrect timestamp

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.