Beginner FriendlyFoundryNFT
100 EXP
View results
Submission Details
Severity: low
Valid

`Dussehra:killRavana()` is callable at non-intended timestamps

Summary

As per documentation:

Allows users to kill Ravana and Organiser will get half of the total amount collected in the event. this function will only work after 12th October 2024 and before 13th October 2024.

However, the timestamps which are used in the implementation, are slightly incorrect:

  • 1728691069 is 11th October 2024 23:57:49

  • 1728777669 is 13th October 2024 00:01:09

Impact

The function is callable before the intended start-time and after the intended end-time.

Recommendations

Change the wrong timestamps to the correct ones:

function killRavana() public RamIsSelected {
- if (block.timestamp < 1728691069) {
+ if (block.timestamp < 1728691200) {
revert Dussehra__MahuratIsNotStart();
}
- if (block.timestamp > 1728777669) {
+ if (block.timestamp > 1728777600) {
revert Dussehra__MahuratIsFinished();
}
// ...
}
Updates

Lead Judging Commences

bube Lead Judge over 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

Incorrect timestamp

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.