First Flight #17: Dussehra

First Flight #17

Beginner FriendlyFoundryNFT

100 EXP

View results

Previous Next

Submission Details

Severity: medium

Invalid

The `ChoosingRam` contract can be changed at any time which breaks the function call `ChoosingRam::increaseValuesOfParticipants`.

poolig4n

Summary
The ChoosingRam contract can be changed at any time which breaks the function call ChoosingRam::increaseValuesOfParticipants. The ability to manipulate the contract at any point may also lead to reduced trust in the protocol, potentially lower participation rates and subsequently the funds generated.

Description

The function RamNFT::setChoosingRamContract allows the organiser to change the ChoosingRam contract in the RamNFT contract. This enables a malicious organiser to manipulate the access controls of the protocol. Breaking the functionality of the call to ChoosingRam::increaseValuesOfParticipants prevents the players from becoming Ram via this game mechanic and leaves the ability to become Ram solely up to the organiser via the ChoosingRam::selectRamIfNotSelected function call. Changing the contract in this way may break the functionality accidentally or it may be of malicious intent.

The documentation states:

ChoosingRam.sol
This contract allows users to increase their values and select Ram if all characteristics are true. If the user has not selected Ram before 12 October 2024, > then the Organizer can select Ram if not selected.

increaseValuesOfParticipants allows users to increase their values(or characteristics) and become Ram for the event. The values will never be updated > again after 12 October 2024.

selectRamIfNotSelected - Allows the organizer to select Ram if not selected by the user.

The Relevant code is shown below:

modifier onlyOrganiser() {

if (msg.sender != organiser) {

revert RamNFT__NotOrganiser();

}

function setChoosingRamContract(address _choosingRamContract)

public onlyOrganiser {

choosingRamContract = _choosingRamContract;

}

Impact

Trust cannot be established by reviewing the protocol as its internal access control mechanisms can change at any time. This may adversely affect the number of willing participants and reduce the potential number of players who will enter. Changing the contract will break the ability for players to become Ram via the intended mechanism within the players control, that is, the functionality provided by: ChoosingRam::increaseValuesOfParticipants.

Proof of Concept

Standalone Test

// SPDX-License-Identifier: UNLICENSED

pragma solidity ^0.8.13;

import {Test, console} from "forge-std/Test.sol";

import {Dussehra} from "../src/Dussehra.sol";

import {ChoosingRam} from "../src/ChoosingRam.sol";

import { mock } from "../src/mocks/mock.sol";

import {RamNFT} from "../src/RamNFT.sol";

contract ChangeContractTest is Test {

// This is the error we'll get when we change the

// contract and try to call

// choosingRam.increaseValuesOfParticipants

error RamNFT__NotChoosingRamContract();

// Stanard testing harness stuff below

Dussehra public dussehra;

RamNFT public ramNFT;

ChoosingRam public choosingRam;

address public organiser = makeAddr("organiser");

address public player1 = makeAddr("player1");

address public player2 = makeAddr("player2");

address public player3 = makeAddr("player3");

address public player4 = makeAddr("player4");

address public player5 = makeAddr("player5");

modifier participants5() {

vm.startPrank(player1);

vm.deal(player1, 1 ether);