Beginner FriendlyFoundryNFT
100 EXP
View results
Submission Details
Severity: low
Invalid

starting the tokenCounter from 0 lead to revert the selectRamIfNotSelected function if no one want to be Ram

Summary

Vulnerability Details

The function relies on the ramNFT.tokenCounter() function to select a RAM item. If ramNFT.tokenCounter() returns 0, indicating no RAM items are available, the function may behave unpredictably or revert.

Impact

If ramNFT.tokenCounter() returns 0, the function may not be able to select a RAM item, leading to unexpected behavior or failures in the RAM selection process.

Tools Used

Manual code review

Recommendations

Error Handling: Implement robust error handling mechanisms to handle cases where ramNFT.tokenCounter() returns 0.
Token Counter Validation: start the counter from 1 in the constructor

Updates

Lead Judging Commences

bube Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

Info/Gas/Invalid according to docs

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.