Beginner FriendlyFoundryNFT
100 EXP
View results
Submission Details
Severity: low
Invalid

Any time a function changes a state variable, an event should be emitted. Many of these events are missing.

[L-8] Any time a function changes a state variable, an event should be emitted. Many of these events are missing throughout the protocol.

Description:

  • Found in src/ChoosingRam.sol

    isRamSelected = true;
  • Found in src/Dussehra.sol

    ramNFT = RamNFT(_ramNFT);
    choosingRamContract = ChoosingRam(_choosingRamContract);
    IsRavanKilled = true;
    totalAmountGivenToRam = 0;
  • Found in src/Dussehra.sol

    organiser = msg.sender;
    choosingRamContract = _choosingRamContract;
    _safeMint(to, newTokenId);
    Characteristics[tokenId] = CharacteristicsOfRam({
    ram: Characteristics[tokenId].ram,
    isJitaKrodhah: _isJitaKrodhah,
    isDhyutimaan: _isDhyutimaan,
    isVidvaan: _isVidvaan,
    isAatmavan: _isAatmavan,
    isSatyavaakyah: _isSatyavaakyah
    });

Recommended Mitigation: Add the missing events.

Updates

Lead Judging Commences

bube Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

Info/Gas/Invalid according to docs

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.