First Flight #17: Dussehra

[L-9] Avoid use of magic numbers: Define and use constant variables instead of using literals.

Description: Using constant variables instead of literals increases readability of code and decreases chances of inadvertently introducing errors.

• Found in src/ChoosingRam.sol

  if (block.timestamp > 1728691200) {

  revert ChoosingRam__TimeToBeLikeRamFinish();

  }
  if (block.timestamp < 1728691200) {

  revert ChoosingRam__TimeToBeLikeRamIsNotFinish();

  }
  if (block.timestamp > 1728777600) {

  revert ChoosingRam__EventIsFinished();

  }

• Found in src/Dussehra.sol

  if (block.timestamp < 1728691069) {

  revert Dussehra__MahuratIsNotStart();

  }
  if (block.timestamp > 1728777669) {

  revert Dussehra__MahuratIsFinished();

  }
  totalAmountGivenToRam = (totalAmountByThePeople * 50) / 100;

Recommended Mitigation: Change these literal values to constants. With the first example:

Apply the same logic to the other literal values.