Beginner FriendlyFoundryNFT
100 EXP
View results
Submission Details
Severity: low
Invalid

The `RamNFT` is a ERC721 token, but does not use any functionality of an ERC token.

[L-11] The RamNFT is a ERC721 token, but does not use any functionality of an ERC token.

Description: The RamNFT is a ERC721 token, but does not use any functionality of an ERC token. Notably:

  1. The NFT is not linked to a uri: as such, it is not linked to an off-chain image or asset.

  2. It is possible to transfer a token to another person, without any impact on the functionality of the protocol. The address that will receive a payout is the address that initially minted the selectedRam, not the address that owns the selected ramNFT.

  3. In general, transferring, trading, burning or any other functionality that comes with an ERC721 token has no impact on the functionality of the broader protocol.

Impact: It does not impact the overall functionality of the protocol, but the unnecessary inclusion of ERC721 does waste gas.

Recommended Mitigation: Either integrate ERC721 functionality into the protocol or remove the ERC721 imports.

Updates

Lead Judging Commences

bube Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

Info/Gas/Invalid according to docs

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.