Submission Details
Severity:
Lack of zero adress checks
Summary
Lack of zero address checks.
Vulnerability Details
There is no zero address check for _choosingRamContract and _ramNFT in the constructor of the Dussehra.sol contract.
https://github.com/Cyfrin/2024-06-Dussehra/blob/main/src/Dussehra.sol#L45
constructor(uint256 _entranceFee, address _choosingRamContract, address _ramNFT) {
entranceFee = _entranceFee;
organiser = msg.sender;
ramNFT = RamNFT(_ramNFT);
choosingRamContract = ChoosingRam(_choosingRamContract);
}
Impact
Lack of zero address check may lead to setting wrong ramNFT address and choosingRamContract address in the constructor.
Tools Used
Manual Review
Recommendations
Add a zero address check.
Updates
Lead Judging Commences
bube about 1 year ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
Info/Gas/Invalid according to docs
Rewards breakdown
nSLOC
218This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.