First Flight #17: Dussehra

Summary

The function Dussehra::killRavana should work after 12 October 2024 and before 13 October 2024. But the timestamp represents different values.

Vulnerability Details

In killRavana function we have these two checks

But 1728691069 represents the date "11 October 2024 23:57:49" instead of "12 October 2024 00:00:00".

Same this for 1728777669, it represents "13 October 2024 00:01:09" instead of "13 October 2024 00:00:00"

Impact

The incorrect representation of these timestamp values may result in the killRavana function being prematurely or belatedly enabled or disabled. This inconsistency could lead to unexpected behavior during the execution of the function, potentially affecting the fairness and reliability of the contract operations.

Tools Used

Manual review

Recommendations

Update the timestamp values in the killRavana function to accurately reflect the intended start and end times of operation (12 October 2024 and 13 October 2024). Preferably using a constant value instead of magic numbers. Ensure that the checks align precisely with these dates to avoid confusion and maintain the contract's intended functionality.