Beginner FriendlyFoundryNFT
100 EXP
View results
Submission Details
Severity: high
Invalid

Anyone can mint the RamNFT in `mintRamNFT` function , as it has no check for who can mint the RamNFT

Summary

As we can clearly see below that the mint function doesn't have any check for who can mint the RamNFT

-->> function mintRamNFT(address to) public {
uint256 newTokenId = tokenCounter++;
_safeMint(to, newTokenId);
Characteristics[newTokenId] = CharacteristicsOfRam({
ram: to,
isJitaKrodhah: false,
isDhyutimaan: false,
isVidvaan: false,
isAatmavan: false,
isSatyavaakyah: false
});
}

Impact

Anyone can mint the RamNFT , which may cause loss to the protocol

Tools Used

Manual Review

Recommendations

  1. Use the onlyOragniser modifier or the onlyChoosingRamContract

  2. Have some checks for who can mint the RamNFT

Updates

Lead Judging Commences

bube Lead Judge over 1 year ago
Submission Judgement Published
Invalidated
Reason: Too generic
Assigned finding tags:

mintRamNFT is public

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.