Submission Details
Severity:
`public` functions not used internally could be marked `external`
Summary
Instead of marking a function as public, consider marking it as external if it is not used internally.
10 Found Instances
-
Found in src/ChoosingRam.sol Line: 35
function increaseValuesOfParticipants(uint256 tokenIdOfChallenger, uint256 tokenIdOfAnyPerticipent) -
Found in src/ChoosingRam.sol Line: 85
function selectRamIfNotSelected() public RamIsNotSelected OnlyOrganiser { -
Found in src/Dussehra.sol Line: 54
function enterPeopleWhoLikeRam() public payable { -
Found in src/Dussehra.sol Line: 69
function killRavana() public RamIsSelected { -
Found in src/Dussehra.sol Line: 83
function withdraw() public RamIsSelected OnlyRam RavanKilled { -
Found in src/RamNFT.sol Line: 47
function setChoosingRamContract(address _choosingRamContract) public onlyOrganiser { -
Found in src/RamNFT.sol Line: 51
function mintRamNFT(address to) public { -
Found in src/RamNFT.sol Line: 65
function updateCharacteristics( -
Found in src/RamNFT.sol Line: 84
function getCharacteristics(uint256 tokenId) public view returns (CharacteristicsOfRam memory) { -
Found in src/RamNFT.sol Line: 88
function getNextTokenId() public view returns (uint256) {
Tools Used
Manual Review , aderyn
Recommendations
Make them external if not used internally
Updates
Lead Judging Commences
bube over 1 year ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
Info/Gas/Invalid according to docs
Rewards breakdown
nSLOC
218This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.