First Flight #17: Dussehra
First Flight #17
Beginner FriendlyFoundryNFT
100 EXP
View results
Previous Next
Submission Details
Severity: low
Invalid

`Dussehra.sol , ChoosingRam.sol` uses timestamp for comparison which can be manipulated by the miners

blockbuddy19

Summary

-->> if (block.timestamp > 1728691200) {
revert ChoosingRam__TimeToBeLikeRamFinish();
}
​
function killRavana() public RamIsSelected {
​
-->> if (block.timestamp < 1728691069) {
revert Dussehra__MahuratIsNotStart();
}
-->> if (block.timestamp > 1728777669) {
revert Dussehra__MahuratIsFinished();
}

Impact

Can be maipulated by the miner for his benefit..!!

Tools Used

Manual Review

Recommendations

  1. Use constant varialbes intead of literals

  2. Rather than using a hardcoded timestamp make it such that it should be chnaged according to the need but only by the owner.

Updates

Lead Judging Commences

bube Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.