Submission Details
Severity:
In `ChoosingRam::increaseValuesOfParticipants` function booleans are compared with booloean constants
Summary
Some Instances
if (random == 0) {
if (ramNFT.getCharacteristics(tokenIdOfChallenger).isJitaKrodhah == false) {
ramNFT.updateCharacteristics(
tokenIdOfChallenger,
true,
false,
false,
false,
false
);
} else if (
ramNFT.getCharacteristics(tokenIdOfChallenger).isDhyutimaan == false
) {
ramNFT.updateCharacteristics(
tokenIdOfChallenger,
true,
true,
false,
false,
false
);
} else if (
ramNFT.getCharacteristics(tokenIdOfChallenger).isVidvaan == false
) {
ramNFT.updateCharacteristics(
tokenIdOfChallenger,
true,
true,
true,
false,
false
);
} else if (
ramNFT.getCharacteristics(tokenIdOfChallenger).isAatmavan == false
) {
ramNFT.updateCharacteristics(
tokenIdOfChallenger,
true,
true,
true,
true,
false
);
} else if (
ramNFT.getCharacteristics(tokenIdOfChallenger).isSatyavaakyah == false
) {
ramNFT.updateCharacteristics(
tokenIdOfChallenger,
true,
true,
true,
true,
true
);
selectedRam = ramNFT.getCharacteristics(tokenIdOfChallenger).ram;
}
} else {
if (
ramNFT.getCharacteristics(tokenIdOfAnyPerticipent).isJitaKrodhah == false
) {
ramNFT.updateCharacteristics(
tokenIdOfAnyPerticipent,
true,
false,
false,
false,
false
);
} else if (
ramNFT.getCharacteristics(tokenIdOfAnyPerticipent).isDhyutimaan == false
) {
ramNFT.updateCharacteristics(
tokenIdOfAnyPerticipent,
true,
true,
false,
false,
false
);
} else if (
ramNFT.getCharacteristics(tokenIdOfAnyPerticipent).isVidvaan == false
) {
ramNFT.updateCharacteristics(
tokenIdOfAnyPerticipent,
true,
true,
true,
false,
false
);
} else if (
ramNFT.getCharacteristics(tokenIdOfAnyPerticipent).isAatmavan == false
) {
ramNFT.updateCharacteristics(
tokenIdOfAnyPerticipent,
true,
true,
true,
true,
false
);
} else if (
ramNFT.getCharacteristics(tokenIdOfAnyPerticipent).isSatyavaakyah == false
) {
ramNFT.updateCharacteristics(
tokenIdOfAnyPerticipent,
true,
true,
true,
true,
true
);
selectedRam = ramNFT.getCharacteristics(tokenIdOfAnyPerticipent).ram;
}
}
Tools Used
Manual Review
Recommendations
Booleans can directly be checked for true or false rather than comparing them to a boolean constant
Updates
Lead Judging Commences
bube about 1 year ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
Info/Gas/Invalid according to docs
Rewards breakdown
nSLOC
218This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.