First Flight #17: Dussehra
First Flight #17
Beginner FriendlyFoundryNFT
100 EXP
View results
Previous Next
Submission Details
Severity: low
Invalid

Tokens in `RamNFT` contract have empty token URI.

mirkopezo

Vulnerability Details

@> contract RamNFT is ERC721URIStorage {
error RamNFT__NotOrganiser();
error RamNFT__NotChoosingRamContract();
​
.
.

Each NFT is usually represented with token URI, it is URL that points to JSON file which contains metadata of NFT. Problem arises because all tokens from RamNFT contract return empty token URI when calling RamNFT::tokenURI function. This especially concerning because developers inherited code from ERC721URIStorage contract, which means they probably wanted to set token URIs for each token.

Impact

Tokens return empty token URI which should not be desired.

Tools Used

Manual review

Recommendations

Add valid token URI which represents JSON file for each token. In this scenario it could be same token URI for all tokens.

Updates

Lead Judging Commences

bube Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

Info/Gas/Invalid according to docs

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.