Beginner FriendlyFoundryNFT
100 EXP
View results
Submission Details
Severity: low
Invalid

Lack of event emission and immutable optimization

Summary

The RamNFT contract currently lacks event emissions for critical state changes and doesn't utilize the immutable keyword for variables set in the constructor. Addressing these issues can improve transparency and gas efficiency.

Vulnerability Details

  1. Lack of event emission

Impact: The contract does not emit events for minting NFTs and updating characteristics, which reduces transparency and makes it difficult to track these actions off-chain. Events are crucial for monitoring contract activity and debugging.

Tools Used: Manual code review.

Recommendation: Add event emissions for the mintRamNFT and updateCharacteristics functions.

  1. Immutable Optimization

Impact: The organiser variable, which is set in the constructor and never changed, should be marked as immutable to save gas and enhance efficiency.

Tools Used: Manual code review.

Recommendation: Update the organiser declaration to use the immutable keyword.

Updates

Lead Judging Commences

bube Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

Info/Gas/Invalid according to docs

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.