Beginner FriendlyFoundryNFT
100 EXP
View results
Submission Details
Severity: high
Invalid

Reentrancy Vulnerability in `updateCharacteristics`

Summary

The updateCharacteristics function of RamNFT is called multiple times within increaseValuesOfParticipants. If RamNFT contract allows for external calls or state changes, this could be exploited.

Vulnerability Details

import {ReentrancyGuard} from "@openzeppelin/contracts/security/ReentrancyGuard.sol";
contract ChoosingRam is ReentrancyGuard {
...
function increaseValuesOfParticipants(uint256 tokenIdOfChallenger, uint256 tokenIdOfAnyPerticipent)
public
RamIsNotSelected
nonReentrant
{
...
}
}

Impact

This could lead to reentrancy attacks where state changes are manipulated.

Tools Used

Manual review

Recommendations

Add a ReentrancyGuard to the ChoosingRam contract.

Updates

Lead Judging Commences

bube Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Incorrect statement

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.