Beginner FriendlyFoundryNFT
100 EXP
View results
Submission Details
Severity: low
Invalid

Hardcoded Timestamps

Summary

While hardcoded timestamps reduce flexibility and can lead to potential issues if the deployment doesn't match the expected timeline, they don't pose a direct security risk. It's more about usability and maintainability.

Vulnerability Details

uint256 public constant SELECTION_START_TIME = 1728691200;
uint256 public constant SELECTION_ENDING_TIME = 1728777600;
if (block.timestamp < SELECTION_START_TIME) {
revert ChoosingRam__TimeToBeLikeRamIsNotFinish();
}
if (block.timestamp > SELECTION_ENDING_TIME) {
revert ChoosingRam__EventIsFinished();
}

Impact

This can make the contract less flexible and prone to errors if the deployment time doesn't match the expected time.

Tools Used

Manual review

Recommendations

Consider using a more flexible system for managing event timelines, possibly with initialization parameters.

Updates

Lead Judging Commences

bube Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

Info/Gas/Invalid according to docs

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.